London | 26-ITP-May | Eyob Zeray | Sprint 2 | Book Library - #502
London | 26-ITP-May | Eyob Zeray | Sprint 2 | Book Library#502eyob-tech wants to merge 6 commits into
Conversation
…thor field, delete button, read status logic
…thor field, delete button, read status logic, missing author validation
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
…isions, simplify delete timing, use const and textContent, improve naming
…ate tags, add lang attribute
|
Thanks for the pointer! Went through the general feedback doc and applied everything relevant to book-library: |
cjyuan
left a comment
There was a problem hiding this comment.
A good start.
I have some suggestions to further improve the code.
…sanitize input, clear table via tbody, non-blocking delete message, enforce whole-number page validation, fix meta tag indentation
|
All changes are great and all responses are spot on. Excellent job! |
Changelist
Fixed the following bugs in the Book Library debugging exercise:
Tested manually in the browser: books display on load, adding a book with all fields works correctly, missing fields trigger the alert, read status toggles correctly, and delete removes the correct book.
Learners, PR Template
Self checklist
Changelist
Fixed the bugs listed in the README: